Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat annotations as redefinitions in .pyi files #10512

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

charliermarsh
Copy link
Member

Summary

In #10341, we fixed some false positives in .pyi files, but introduced others. This PR effectively reverts the change in #10341 and fixes it in a slightly different way. Instead of changing the bindings we generate in the semantic model in .pyi files, we instead change how we resolve them.

Closes #10509.

@charliermarsh charliermarsh added the bug Something isn't working label Mar 21, 2024
@charliermarsh charliermarsh requested review from MichaReiser and AlexWaygood and removed request for MichaReiser March 21, 2024 16:07
@AlexWaygood
Copy link
Member

Nice, this looks good! Let me just run this branch on typeshed quickly.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it fixes the regressions for typeshed, and doesn't introduce any new ones (with our current config, at least)!

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit caa1450 into main Mar 21, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/F811 branch March 21, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants